Do not rely on GT_ADDR in gtFoldBoxNullable#69961
Merged
Merged
Conversation
ghost
added
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsInstead, get the class handle from the helper arg node.
|
SingleAccretion
force-pushed
the
Box-Nullable-Cmp-Null
branch
from
2a84172 to
42d9bf0
Compare
Merged
Contributor
Author
|
CI failures:
@dotnet/jit-contrib |
We can obtain the "Nullable<T>" class handle from the helper's arg.
SingleAccretion
force-pushed
the
Box-Nullable-Cmp-Null
branch
from
42d9bf0 to
ad8d99f
Compare
jakobbotsch
approved these changes
Jun 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead, get the class handle from the helper arg node.
Diffs.